Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being able to disable prom annotations #399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Being able to disable prom annotations #399

wants to merge 2 commits into from

Conversation

SmaineTF1
Copy link
Contributor

@SmaineTF1 SmaineTF1 commented Jul 3, 2023 •
edited
Loading

What was changed

Default behavior should be to have the annotations disabled at the service level.
Note that it is already enabled at the global level by default:

server:
  metrics:
    annotations:
      enabled: true

Why?

That makes easier to configure if you use the prometheus operator for instance

@SmaineTF1 SmaineTF1 requested review from a team as code owners July 3, 2023 13:24
@SmaineTF1 SmaineTF1 changed the title Fix/disable prom annotations opt Being able to disable prom annotations Jul 3, 2023
@SmaineTF1
Copy link
Contributor Author

Do you need more info?

@robholland
Copy link
Contributor

This is backwards incompatible, you are changing the defaults such that new users would not get the annotations. You aren't considering the top-level setting.

@robholland robholland requested review from a team and removed request for a team June 14, 2024 08:03
@robholland robholland added the needs revision Team has requested some changes label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs revision Team has requested some changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SmaineTF1 @robholland